adding test coverage for route precedence as per issue #996 #1011

Merged
merged 1 commit into from Feb 15, 2012

Conversation

Projects
None yet
3 participants
Collaborator

wookiehangover commented Feb 15, 2012

As discussed in #996, this adds a test case for routes being executed in the order of most specific to least specific. Common sense, but this test should catch any potential regressions in the api.

@jashkenas jashkenas added a commit that referenced this pull request Feb 15, 2012

@jashkenas jashkenas Merge pull request #1011 from wookiehangover/issue996
adding test coverage for route precedence as per issue #996
e5db1c9

@jashkenas jashkenas merged commit e5db1c9 into jashkenas:master Feb 15, 2012

machty commented May 18, 2012

Hi, sorry, somewhat of a backbone noob here, but considering that property order isn't guaranteed when iterating over a JS object, how can there be any enforced precedence of backbone routers? Is it just the case that the order is guaranteed by most browsers (particularly the one used for these cases), so it's not really a problem?

Owner

jashkenas commented May 21, 2012

Yep -- it wasn't in the spec, but browsers now all preserve iteration order in objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment