Forced options to be an object on collection.fetch#1058
Closed
Gazler wants to merge 1 commit intojashkenas:masterfrom
Closed
Forced options to be an object on collection.fetch#1058Gazler wants to merge 1 commit intojashkenas:masterfrom
Gazler wants to merge 1 commit intojashkenas:masterfrom
Conversation
Owner
|
Why would you call |
Author
|
In the specific example, I was using it as a callback from pusher and I wanted to call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On collection.fetch, the argument being sent through will default to an empty object if the object sent through is not an object. This is because if you call
collection.fetchwith an array as an argument (for example in a callback) then the "reset" event is not triggered.