New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass fetch options to success function. #1355

Merged
merged 2 commits into from Jun 1, 2012

Conversation

Projects
None yet
3 participants
@felixhorro
Contributor

felixhorro commented May 29, 2012

It will allow to use context (an other options) in callback function on success.

Pass fetch options to success function (as error function does).
It will allow to use context (an other options) in callback function on success.
@braddunbar

This comment has been minimized.

Show comment
Hide comment
@braddunbar

braddunbar May 29, 2012

Collaborator

This seems reasonable to me. However, if we're going to pass the options to the success function for fetch, I think we should do the same for save, create, and destroy.

Collaborator

braddunbar commented May 29, 2012

This seems reasonable to me. However, if we're going to pass the options to the success function for fetch, I think we should do the same for save, create, and destroy.

@felixhorro

This comment has been minimized.

Show comment
Hide comment
@felixhorro

felixhorro May 30, 2012

Contributor

You're right. Commited.

Contributor

felixhorro commented May 30, 2012

You're right. Commited.

@braddunbar

This comment has been minimized.

Show comment
Hide comment
@braddunbar

braddunbar May 30, 2012

Collaborator

LGTM. Can we get some tests in there before we merge this?

Collaborator

braddunbar commented May 30, 2012

LGTM. Can we get some tests in there before we merge this?

wookiehangover pushed a commit to wookiehangover/backbone that referenced this pull request May 30, 2012

@wookiehangover

This comment has been minimized.

Show comment
Hide comment
@wookiehangover

wookiehangover May 30, 2012

Collaborator

@braddunbar just added some tests for this :feelsgood:

Collaborator

wookiehangover commented May 30, 2012

@braddunbar just added some tests for this :feelsgood:

@braddunbar braddunbar merged commit 6250b63 into jashkenas:master Jun 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment