New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getValue for View::className and View::id #1520

Merged
merged 1 commit into from Aug 8, 2012

Conversation

Projects
None yet
4 participants
@gsamokovarov
Contributor

gsamokovarov commented Aug 1, 2012

tagName can be a function, let id and className be functions too.

@wookiehangover

This comment has been minimized.

Show comment
Hide comment
@wookiehangover

wookiehangover Aug 8, 2012

Collaborator

This is something I've needed in the past, looks good to me

+1

Collaborator

wookiehangover commented Aug 8, 2012

This is something I've needed in the past, looks good to me

+1

@braddunbar

This comment has been minimized.

Show comment
Hide comment
@braddunbar

braddunbar Aug 8, 2012

Collaborator

Agreed. It's handy and more consistent with other properties.

Collaborator

braddunbar commented Aug 8, 2012

Agreed. It's handy and more consistent with other properties.

@jashkenas

This comment has been minimized.

Show comment
Hide comment
@jashkenas

jashkenas Aug 8, 2012

Owner

Alright then.

Owner

jashkenas commented Aug 8, 2012

Alright then.

jashkenas added a commit that referenced this pull request Aug 8, 2012

Merge pull request #1520 from gsamokovarov/getvalue-id-classname
getValue for View::className and View::id

@jashkenas jashkenas merged commit 41333df into jashkenas:master Aug 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment