Fix #1943 - use _.isEqual to check model change #1944

Merged
merged 1 commit into from Dec 14, 2012

Conversation

Projects
None yet
3 participants
@tgriesser
Collaborator

tgriesser commented Dec 14, 2012

Looks like this was an oversight when I reworked the set/change internals - includes a test of this functionality.

@carlsverre

This comment has been minimized.

Show comment Hide comment
@carlsverre

carlsverre Dec 14, 2012

👍

👍

@jashkenas

This comment has been minimized.

Show comment Hide comment
@jashkenas

jashkenas Dec 14, 2012

Owner

Wow. That's not good. I can't believe we didn't have a test for it. May need to push a patch version ASAP.

Owner

jashkenas commented Dec 14, 2012

Wow. That's not good. I can't believe we didn't have a test for it. May need to push a patch version ASAP.

jashkenas added a commit that referenced this pull request Dec 14, 2012

Merge pull request #1944 from tgriesser/isEqualChange
Fix #1943 - use _.isEqual to check model change

@jashkenas jashkenas merged commit c1a9384 into jashkenas:master Dec 14, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment