Pass along `textStatus` and `errorThrown`. #3048

Merged
merged 1 commit into from Mar 15, 2014

Projects

None yet

2 participants

Collaborator

No description provided.

Collaborator

Since this is jQuery/ajax specific, I think it's fine to go in the default Backbone.sync. That said, it doesn't fall in the 90% rule and can be done just as easily with a custom wrapper. Either way is fine by me.

Owner

If you're passing along the arguments in this way — then how it it not the case that textStatus and errorThrown aren't passed in as arguments directly? Am I reading it wrong?

Collaborator

No, you're correct. It's just that there's a bit of misdirection because error is set up via wrapError, which juggles the arguments before calling through.

@jashkenas jashkenas merged commit 2543be2 into jashkenas:master Mar 15, 2014

1 check passed

default The Travis CI build passed
Details
@braddunbar braddunbar deleted the braddunbar:error branch Mar 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment