hasChanged/set should use the same comparison #842

Merged
merged 1 commit into from Jan 6, 2012

2 participants

@braddunbar
Collaborator

When setting a value, if hasChanged and set disagree about equality then hasChanged will return true without firing a 'changed:*' event (or vice versa). Using the same comparison (_.isEqual) solves this problem.

@braddunbar braddunbar hasChanged/set should use the same comparison
When setting a value, if hasChanged and set disagree
about equality then hasChanged will return true without
firing a 'changed:*' event (or vice versa).  Using the
same comparison (_.isEqual) solves this problem.
934aba4
@jashkenas jashkenas merged commit 060da2b into jashkenas:master Jan 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment