Massive rewrite #101

Merged
merged 2 commits into from Mar 26, 2012

Conversation

Projects
None yet
3 participants
@paulmillr
Contributor

paulmillr commented Mar 23, 2012

  • Disable very annoying auto-indentation in textmate 2, just as in Python
  • Fix bug when -> was treated as two operators (- and >).
  • Fix color of function arguments.
  • Add highlighting of:
    • spread operator.
    • built-in classes / constructors.
    • built-in array methods
    • static built-in methods
    • global functions

Before:

After:

jashkenas added a commit that referenced this pull request Mar 26, 2012

@jashkenas jashkenas merged commit ae1c34c into jashkenas:master Mar 26, 2012

@Hubro

This comment has been minimized.

Show comment
Hide comment
@Hubro

Hubro Mar 29, 2012

This massive rewrite broke something, I can't tell what. All I know is that Sublime Text now gets confused about what functions are. I've attached before and after screenshots to illustrate what I mean:

Before (at 2930525):
before

After (at master HEAD):
after

Hubro commented Mar 29, 2012

This massive rewrite broke something, I can't tell what. All I know is that Sublime Text now gets confused about what functions are. I've attached before and after screenshots to illustrate what I mean:

Before (at 2930525):
before

After (at master HEAD):
after

@jashkenas

This comment has been minimized.

Show comment
Hide comment
@jashkenas

jashkenas Mar 29, 2012

Owner

@paulmillr Can you take a crack at fixing this? Otherwise we may have to revert your change.

Owner

jashkenas commented Mar 29, 2012

@paulmillr Can you take a crack at fixing this? Otherwise we may have to revert your change.

@paulmillr

This comment has been minimized.

Show comment
Hide comment
@paulmillr

paulmillr Mar 29, 2012

Contributor

@jashkenas yep.

Contributor

paulmillr commented Mar 29, 2012

@jashkenas yep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment