Fixed improper scoping of siblings to the splat argument. #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x = 10 ([x]) -> # used to not declare var x this is one fix, the other way to fix it is to remove the entire if ... olen is 1 .... block... not sure if that's a good idea or not.
|
Before evaluting this pull request -- mind fixing it to remove the changes to the documentation, to extras/coffee-script.js, and to index.html? |
|
right, wasn't sure about those... |
|
so you do want the changes to lib/nodes.js, right? |
jashkenas
added a commit
that referenced
this pull request
May 16, 2011
Fixed improper scoping of siblings to the splat argument.
|
Yep -- well done. |
|
Cool, this was my first pull request. Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splat scope fixes now on a branch. (original request #1336)
The only real changes here are in src/nodes.coffee and the two new tests, (everything else is downstream of cake and rake)