REPL rewrite #2682
Merged
REPL rewrite #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into node_repl
…Includes multiline tests.
We can still use some more extensive tests, but it's already much better tested than the current REPL.
|
Those multiline bits are pretty nasty ... and I'm still not convinced that anyone uses it, but hey -- let's go for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obsoletes #2669 and #2600. Ping @jashkenas for final approval.
Should we squash some of these commits or just keep them all separate? We still have the somewhat-hacky replacement of newlines with a reserved unicode character when in multiline mode. I don't know a better solution, and it's not terrible as is. We could also use a few more tests, but that can wait. It's already in a better state than the current REPL.