-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix require.extensions registration #3279
fix require.extensions registration #3279
Conversation
You can now `require('coffee-script/register')` to manually register, and the compiler auto-registers when directly running a coffee file.
We should already have tests for this, so I'd say LGTM. |
…egistration fix require.extensions registration
@michaelficarra @Nami-Doc We desperately need some documentation for this breaking change. I think it's currently only documented here: |
We'll add it to the changelog when we make a release. Are you suggesting something more? We can make it bold our something. |
Copy that thing somewhere so that people trying master don't have to hunt it down (even in the issues you quoted, the mechanism wasn't clearly stated), I guess the release notes on the website should be enough since that behavior is only documented there in the first place. |
Okay. For anyone confused about this change, you now must explicitly register the compiler with
The former is the simplest approach if you already have a reference to the compiler, while the latter is handy for mocha configuration and similar needs. |
It's probably worth stating in the relevant documentation that the extension will be 'auto-registered' when a file is run with |
As of [this PR](jashkenas/coffeescript#3279), CoffeeScript now requires Cakefiles to register their local coffee installation as to ensure version compatibility.
Ref #3141, #3054, #2323.