Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

_.values broken on large objects? (that contain `length` key, dup of #148) #154

Closed
DTrejo opened this Issue Mar 21, 2011 · 3 comments

Comments

Projects
None yet
3 participants

DTrejo commented Mar 21, 2011

http://jsfiddle.net/TjA5E/3/

This code does not work.

Notice that it does work for the second and third examples.

I have no idea why this is happening :|
-David

DTrejo commented Mar 21, 2011

I think it may be the length property tricking _.map.

e.g.
console.log('this doesnt work:');
var data = {"a":2.0, "b":3.0, "c":4.0, "�":0.00012251375747504177, length:0.2};
console.log(_.values(data));

Contributor

kitcambridge commented Mar 21, 2011

Yep, you're correct! _.map() delegates to _.each(); see issue #148.

DTrejo commented Mar 21, 2011

I think this should go in the documentation, as mentioned in #148.

@jashkenas jashkenas closed this Apr 15, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment