_.flatten breaking change behaviour 1.6 -> 1.7 (interacting with objects) #1904
Comments
|
From the docs, flatten is not supposed to work on objects. So i'm not surprised of this behaviour. |
|
Hi @theghostbel! While this may have worked incidentally in the past, |
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this issue
Feb 17, 2016
Backbone, from 1.1.2 to 1.2.3. Underscore, from 1.6.0 to 1.8.3. The new versions of Backbone and Underscore offer numerous small bug fixes and some optimizations and other improvements. Check the [http://backbonejs.org/#changelog Backbone changelog] and [http://underscorejs.org/#changelog Underscore changelog] for the full details. The new versions include some significant changes that may break existing code. Plugins or themes that rely on the bundled Backbone and/or Underscore libraries should carefully check functionality with the latest versions and run any available unit tests to ensure compatibility. Some changes of note that were addressed in core as part of this upgrade: * `_.flatten` no longer works with objects since Underscore.js 1.7. `_.flatten()` working with objects was an unintended side-affect of the implementation, see [jashkenas/underscore#1904 (comment) underscore#1904]. Check any `_flatten` usage and only flatten arrays. * As of Backbone 1.2.0, you can no longer modify the `events` hash or your view's `el` property in `initialize`, so don't try to modify them there. * Since Underscore 1.7, Underscore templates no longer accept an initial data object. `_.template` always returns a function now so make sure you use it that way. Props adamsilverstein. Fixes #34350. Built from https://develop.svn.wordpress.org/trunk@36546 git-svn-id: http://core.svn.wordpress.org/trunk@36513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
svn2github
pushed a commit
to svn2github/wp-svn-2-git
that referenced
this issue
Feb 17, 2016
Backbone, from 1.1.2 to 1.2.3. Underscore, from 1.6.0 to 1.8.3. The new versions of Backbone and Underscore offer numerous small bug fixes and some optimizations and other improvements. Check the [http://backbonejs.org/#changelog Backbone changelog] and [http://underscorejs.org/#changelog Underscore changelog] for the full details. The new versions include some significant changes that may break existing code. Plugins or themes that rely on the bundled Backbone and/or Underscore libraries should carefully check functionality with the latest versions and run any available unit tests to ensure compatibility. Some changes of note that were addressed in core as part of this upgrade: * `_.flatten` no longer works with objects since Underscore.js 1.7. `_.flatten()` working with objects was an unintended side-affect of the implementation, see [jashkenas/underscore#1904 (comment) underscore#1904]. Check any `_flatten` usage and only flatten arrays. * As of Backbone 1.2.0, you can no longer modify the `events` hash or your view's `el` property in `initialize`, so don't try to modify them there. * Since Underscore 1.7, Underscore templates no longer accept an initial data object. `_.template` always returns a function now so make sure you use it that way. Props adamsilverstein. Fixes #34350. Built from https://develop.svn.wordpress.org/trunk@36546 git-svn-id: http://core.svn.wordpress.org/trunk@36513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this issue
Feb 16, 2017
Backbone, from 1.1.2 to 1.2.3. Underscore, from 1.6.0 to 1.8.3. The new versions of Backbone and Underscore offer numerous small bug fixes and some optimizations and other improvements. Check the [http://backbonejs.org/#changelog Backbone changelog] and [http://underscorejs.org/#changelog Underscore changelog] for the full details. The new versions include some significant changes that may break existing code. Plugins or themes that rely on the bundled Backbone and/or Underscore libraries should carefully check functionality with the latest versions and run any available unit tests to ensure compatibility. Some changes of note that were addressed in core as part of this upgrade: * `_.flatten` no longer works with objects since Underscore.js 1.7. `_.flatten()` working with objects was an unintended side-affect of the implementation, see [jashkenas/underscore#1904 (comment) underscore#1904]. Check any `_flatten` usage and only flatten arrays. * As of Backbone 1.2.0, you can no longer modify the `events` hash or your view's `el` property in `initialize`, so don't try to modify them there. * Since Underscore 1.7, Underscore templates no longer accept an initial data object. `_.template` always returns a function now so make sure you use it that way. Props adamsilverstein. Fixes #34350. git-svn-id: https://develop.svn.wordpress.org/trunk@36546 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Check this code:
in 1.6.0 it returns
[1, 2]and in 1.7.0 -[]1.7.0 -http://jsbin.com/gowonebipe/1/
1.6.0 - http://jsbin.com/yaqayohaqa/1/
Will this "feature" be back to core?
The text was updated successfully, but these errors were encountered: