Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss latest changes to master before releasing #2061

Closed
jamiebuilds opened this issue Feb 20, 2015 · 11 comments
Closed

Discuss latest changes to master before releasing #2061

jamiebuilds opened this issue Feb 20, 2015 · 11 comments
Labels

Comments

@jamiebuilds
Copy link
Contributor

@jamiebuilds jamiebuilds commented Feb 20, 2015

There are a lot of changes happening right now that have not been discussed, including breaking changes.

6d3100e...master

At the very least these should be pull requests that other contributors can discuss.

Changes include:

  • Removing _.transform
  • Removing _.create
  • Renaming _.keysIn to _.allKeys
  • Renaming _.mapValues to _.mapObject
  • Renaming _.assign to _.extendOwn
  • Renaming _.matches to _.isMatch
  • Adding _.matcher alias _.matches
  • Reverted some changes in 1.7 (ie. _.extend)
@jamiebuilds
Copy link
Contributor Author

@jamiebuilds jamiebuilds commented Feb 20, 2015

@jashkenas
Copy link
Owner

@jashkenas jashkenas commented Feb 20, 2015

Too late indeed. We can follow up with a 1.8.1 pronto if needed. Hopefully it won't be...

@jashkenas jashkenas added the question label Feb 20, 2015
@jridgewell
Copy link
Collaborator

@jridgewell jridgewell commented Feb 20, 2015

Renaming _.matches to _.isMatch
Adding _.matcher alias _.matches

Those were both fixed. 1.7's _.matches is 1.8's _.matcher = _.matches. 1.8's _.isMatch is what you expect it is.

@jridgewell
Copy link
Collaborator

@jridgewell jridgewell commented Feb 20, 2015

Reverted some changes in 1.7 (ie. _.extend)

1.8 has the same behavior as 1.6, which is intentional b17bd67.

@jridgewell
Copy link
Collaborator

@jridgewell jridgewell commented Feb 20, 2015

Do you mind cleaning up the ones that weren't changes made last minute by @jashkenas? _.matches, _.matcher, _.isMatch, and _.extend aren't undiscussed issues.

I'd love for this to be the jumping off point to fix 1.8 with 1.8.1. And this time, let's actually fix it.

@jridgewell
Copy link
Collaborator

@jridgewell jridgewell commented Feb 20, 2015

Additionally, we have a breaking change to a brand new feature in 1.7: Overriding _.iteratee no longer changes the behavior of the collection iterators. Fix is #1965.

@jashkenas Please revoke 1.8 from npm. Let's get these issues worked out, and ship a 1.8.1.

@jashkenas
Copy link
Owner

@jashkenas jashkenas commented Feb 20, 2015

I don't think we should allow overriding iteratee. It's not a very pleasant API — so that change is alright.

I'm more concerned about the IE8 test failures. What on earth happened to poor old IE?

@jridgewell
Copy link
Collaborator

@jridgewell jridgewell commented Feb 20, 2015

I don't think we should allow overriding iteratee. It's not a very pleasant API — so that change is alright.

But #1582... and it was brand new!

@jridgewell
Copy link
Collaborator

@jridgewell jridgewell commented Feb 20, 2015

Adding to this:

jridgewell added a commit to jridgewell/underscore that referenced this issue Feb 20, 2015
For the record, I like `_.mapObject` better. But this change was
undiscussed.

Re: jashkenas#2061, 4f771e0
jridgewell added a commit to jridgewell/underscore that referenced this issue Feb 20, 2015
For the record, I like `_.mapObject` better. But this change was
undiscussed.

Re: jashkenas#2061, 4f771e0
@AdamHess
Copy link

@AdamHess AdamHess commented Feb 22, 2015

Guys USE SEMVER! These sort of breaking changes should make this pump up a complete version number!

@jridgewell
Copy link
Collaborator

@jridgewell jridgewell commented Feb 23, 2015

Closing this since there are relevant PRs for each of the changes.

  • Removing _.transform
  • Removing _.create
  • Renaming _.keysIn to _.allKeys
  • Renaming _.mapValues to _.mapObject
  • Renaming _.assign to _.extendOwn
  • Renaming _.matches to _.isMatch
  • Adding _.matcher alias _.matches
  • Reverted some changes in 1.7 (ie. _.extend)
@jridgewell jridgewell closed this Feb 23, 2015
jridgewell added a commit to jridgewell/underscore that referenced this issue Jan 14, 2016
For the record, I like `_.mapObject` better. But this change was
undiscussed.

Re: jashkenas#2061, 4f771e0
jridgewell added a commit to jridgewell/underscore that referenced this issue Jan 14, 2016
For the record, I like `_.mapObject` better. But this change was
undiscussed.

Re: jashkenas#2061, 4f771e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.