add in single timeout implementation of debounce #1269

Merged
merged 2 commits into from Sep 7, 2013

Conversation

Projects
None yet
2 participants
@jashkenas

This comment has been minimized.

Show comment
Hide comment
@jashkenas

jashkenas Sep 4, 2013

Owner

Neat! How sure are you that this actually behaves the same way, including edge cases? (Our debounce tests are notoriously iffy.)

Anyone else taken a look over this and had thoughts?

Owner

jashkenas commented Sep 4, 2013

Neat! How sure are you that this actually behaves the same way, including edge cases? (Our debounce tests are notoriously iffy.)

Anyone else taken a look over this and had thoughts?

@rhysbrettbowen

This comment has been minimized.

Show comment
Hide comment
@rhysbrettbowen

rhysbrettbowen Sep 4, 2013

One problem that is possible with this is if someone overrides the Date object.

I'm currently using it in our development application and haven't run in to any issues. It passes the underscore debounce test but as you say, it's not the most rigorous.

One problem that is possible with this is if someone overrides the Date object.

I'm currently using it in our development application and haven't run in to any issues. It passes the underscore debounce test but as you say, it's not the most rigorous.

jashkenas added a commit that referenced this pull request Sep 7, 2013

Merge pull request #1269 from rhysbrettbowen/master
add in single timeout implementation of debounce

@jashkenas jashkenas merged commit 19ab4e4 into jashkenas:master Sep 7, 2013

1 check passed

default The Travis CI build passed
Details

@hanzichi hanzichi referenced this pull request in hanzichi/underscore-analysis Oct 8, 2016

Open

underscore 函数去抖的实现 #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment