add in single timeout implementation of debounce #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat! How sure are you that this actually behaves the same way, including edge cases? (Our debounce tests are notoriously iffy.) Anyone else taken a look over this and had thoughts? |
|
One problem that is possible with this is if someone overrides the Date object. I'm currently using it in our development application and haven't run in to any issues. It passes the underscore debounce test but as you say, it's not the most rigorous. |
jashkenas
added a commit
that referenced
this pull request
Sep 7, 2013
add in single timeout implementation of debounce
kritollm
added a commit
to kritollm/underscore
that referenced
this pull request
Dec 5, 2020
jgonggrijp
added a commit
that referenced
this pull request
Dec 7, 2020
Reimplementing timer optimization #1269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
see http://modernjavascript.blogspot.com/2013/08/building-better-debounce.html for explanation