Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly convert _.sample input collection to array #2944

merged 2 commits into from Dec 16, 2021


Copy link

@jgonggrijp jgonggrijp commented Dec 16, 2021

This fixes #2927, a regression that resulted from #2158. The change is trivial and obvious: _.toArray is our single trusted way to reliably produce arrays from values.

I'm not expecting a review (although reviews are welcome); this pull request is just to leave a trace.

@jgonggrijp jgonggrijp merged commit d9e0091 into jashkenas:master Dec 16, 2021
@jgonggrijp jgonggrijp deleted the fix-sample-string branch Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

1 participant