Added '_.ensureArray' function - #816
Closed
krawaller wants to merge 1 commit into
Closed
Conversation
Collaborator
|
|
Author
|
|
Owner
|
Interesting, but way too special-case for Underscore. There are many situations where an API expects a particular type of object (that may or may not be coerceable from your input) ... and Arrays aren't the only type in town. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a
_.ensureArrayutility function, which we frequently found ourselvesmixininto underscore. As the name implies, it helps when you want to feed a perhaps-array value into an API that expects an array:Semantically we are perhaps treading a bit too far into the land of
_.toArrayhere, but the functions behave very differently sincetoArrayalways treats the argument as a collection. For the above use cases, here is whattoArrayreturns:Only for falsy values do the two functions act the same.