Jun Jiang jasl

Organizations

@ruby-china @beijing-rubyist @19wu @railsgirls-china
jasl commented on issue doorkeeper-gem/doorkeeper#612
@jasl

@tute let's we add JRuby to Travis-CI and tolerate it failure, maybe my team will use JRuby in future and I can working on this(but I can't make a …

jasl commented on pull request doorkeeper-gem/doorkeeper#628
@jasl

It refer to #281 . initialize_application_owner! implemented in ORM Adapter is good to override, or can only extend by monkey patch

jasl commented on pull request doorkeeper-gem/doorkeeper#628
@jasl

I'v no a strong reason, but option like enable_application_owner(there just one for now) may need a extra check, so I allow pass @config to easy to…

jasl commented on pull request doorkeeper-gem/doorkeeper#628
@jasl

there can only raise NameError by constantize, no matter configuration.orm is nil or just invalid.

jasl pushed to master at jasl/doorkeeper
@jasl
jasl commented on pull request doorkeeper-gem/doorkeeper#628
@jasl

no need test this case, cause setup_orm_adapter can only raise NameError by constantize

jasl commented on pull request doorkeeper-gem/doorkeeper#628
@jasl

fixed and travis-ci is green

@jasl
jasl commented on pull request doorkeeper-gem/doorkeeper#628
@jasl

It's just coincide I remember some people want to override it when they implement new ORM adapter this is an option, so keep separate between init…

@jasl
jasl commented on pull request doorkeeper-gem/doorkeeper#628
@jasl

initialize_models! not call in this method, in setup_orm_models it will show the full error stack when initialize_models! raise error, so the tip i…

jasl commented on pull request doorkeeper-gem/doorkeeper#627
@jasl

That's my honor

jasl opened pull request kickstarter/rack-attack#124
@jasl
Update README.md
1 commit with 1 addition and 1 deletion
@jasl
jasl commented on pull request doorkeeper-gem/doorkeeper#629
@jasl

Sorry I can't work for doorkeeper this weekend(my company's site is under attacking), but I would reply your comments ASAP.

jasl commented on pull request doorkeeper-gem/doorkeeper#629
@jasl

It would easy to maintain I think, when I reading the upgrade guide, I was confusion that we don't have the spec_helper.rb. so I use CLI to created…

jasl commented on pull request doorkeeper-gem/doorkeeper#629
@jasl

well, I think follow standard is better.

jasl commented on pull request doorkeeper-gem/doorkeeper#629
@jasl

oh, I found the official upgrade guide use the name spec_helper.rb, but its contents are the same as our spec_helper_integration.rb, so I google th…

jasl commented on pull request doorkeeper-gem/doorkeeper#629
@jasl

I comment some, but maybe I need a long time to understand these cases.

jasl commented on pull request doorkeeper-gem/doorkeeper#629
@jasl

your mean? we could just let before hook run on initializing(using before(:suite)

jasl commented on pull request doorkeeper-gem/doorkeeper#629
@jasl

seems no need, I just follow the upgrade guide and not think about it.

jasl commented on pull request doorkeeper-gem/doorkeeper#629
@jasl

I'v read the Rspec's source code, given is just an alias for let, and it's match for feature

jasl commented on pull request typesafehub/activator#993
@jasl

but it may broken somewhere's style

jasl commented on pull request typesafehub/activator#993
@jasl

@Warry : how about buffering STDOUT on backend?

jasl closed issue jasl/wx_pay#5
@jasl
显示uninitialized constant WxPay::Service::RestClient错误
jasl commented on issue jasl/wx_pay#5
@jasl

抱歉回复晚了,应该是Bug,Service应该只需要rest-client,其他人没有报错可能是因为 rest-client是比较常见的依赖已经被载入到Rails环境中。 总之,我修正了一下,并且更新版本到 0.0.3,你可以试一下。 感谢你的指出!