Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

jasmine init installs deprecated jasmine.rake #62

Closed
jwhitley opened this Issue · 8 comments

8 participants

@jwhitley

This is with the 1.1.0 version of the gem; 1.1.1 is broken per #60 so I can't test with it.

Repro steps:

rails new foo
cd foo
echo "gem 'jasmine', '1.1.0'" >> Gemfile
bundle update
jasmine init
rake -T

Expected result: works, no complaints.

Actual result, giant deprecation warning due to jasmine init still installing the now-deprecated lib/tasks/jasmine.rake:

>> rake -T

            You no longer need to have jasmine.rake in your project, as it is now automatically loaded
            from the Jasmine gem. To silence this warning, set "USE_JASMINE_RAKE=true" in your environment
            or remove jasmine.rake.

rake about              # List versions of all Rails frameworks and the environment
rake assets:clean       # Remove compiled assets
[...]
@jsmestad

+1 :thumbsup:

This fixes the issue for me also.

@rhunter

I'm seeing the same thing with jasmine-1.1.2:
jasmine init && rake -T complains with a deprecation warning

If I remove lib/tasks/jasmine.rake then the Jasmine task is invisible (in my Rails 3.1 project):

 rake aborted!
 Don't know how to build task 'jasmine'
@pietere

I have the same issue

@Harlley

I have the same issue

@ragaskar
Owner

Not sure what the fix is here (there's no commits with this particular pull), but Rails projects should generally use the generators, not jasmine init. I'm not sure if jasmine init still works for any version of Rails, but we'll take a look.

@jwhitley

@ragaskar no commits => this isn't a pull request, just a plain issue.

I believe I filed this back when starting work on a new Rails 3.1 project. IIRC, the generators just errored out as they hadn't been updated for Rails 3. If jasmine init isn't intended for Rails projects, then it's easily good enough to kick out an informational message when run from a Rails root directory ala:

It looks like you've got a Rails app.  We recommend running the Jasmine Rails generator, like so:
   rails g jasmine

If you're not actually using a Rails app, then you can override this warning like so:
   jasmine init --force
@jboyens
Owner

Fixed in e071474

@jboyens jboyens closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.