Fixes file-ordering bug in files loaded from jasmine.yml #137

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@dwwoelfel

On OSX, directory contents are always ordered the same, due to OSX's HFS+ file system. On Linux machines however, directory contents do not have a defined order.

This means every OSX system will load the files in the same order, but different linux machines will load the files in different orders. This pull request sorts the files specified in the jasmine.yml so that the file-order is the same across file-systems.

If a user had a jasmine.yml with

helpers:
  - "helpers/sinon/*.js"

Then the sinon scripts will likely be included out of order, causing exceptions when a dependency is not defined.

Contributor

+1

@jboyens jboyens was assigned Jul 19, 2013
Owner
jboyens commented Jul 19, 2013

We recently did this in the Python version and I think this is probably a pretty good idea to keep things consistent. Thanks for your contribution.

Owner
jboyens commented Jul 25, 2013

Should be fixed by e60baf8

Needed to modify it slightly to continue to support more than a single glob.

@jboyens jboyens closed this Jul 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment