From 61bf9ac7d7e7f277ef9ba30176e04b0581cdd1dc Mon Sep 17 00:00:00 2001 From: Greg Cobb and Tim Jarratt Date: Thu, 28 Aug 2014 10:24:22 -0700 Subject: [PATCH] Improve quality of async timeout for afterAll spec We found that this test was always passing and had strange interactions with the ordering of other specs. Rewriting it to explicitly finish the afterAll after a specified interval makes it fail correctly. [#73742528] --- spec/core/integration/EnvSpec.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/spec/core/integration/EnvSpec.js b/spec/core/integration/EnvSpec.js index ab8f21492..01925defc 100644 --- a/spec/core/integration/EnvSpec.js +++ b/spec/core/integration/EnvSpec.js @@ -720,13 +720,15 @@ describe("Env integration", function() { }); env.addReporter(reporter); + j$.DEFAULT_TIMEOUT_INTERVAL = 3000; env.describe('my suite', function() { env.it('my spec', function() { }); env.afterAll(function(innerDone) { - jasmine.clock().tick(4312); + jasmine.clock().tick(3001); + innerDone(); }); });