Usage of reserved word, `for` #268

Closed
Olical opened this Issue Aug 14, 2012 · 3 comments

2 participants

@Olical

You are currently using the reserved word, for, on this line. This attribute should be quoted to allow it to work in older browsers that are less lenient. Here is how I have adapted the line to get it to work.

self.createDom('label', { className: 'label', 'for': 'no_try_catch' }, 'No try/catch'),
@Olical

I have added the required fix and submitted it is a pull request.

@Olical

My pull request has been merged in. I have just run it through IE6, 7 and 8 and everything is working perfectly now. Thanks!

@Olical Olical closed this Aug 15, 2012
@ragaskar

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment