rake jasmine:ci not exiting with proper exit code #28

Closed
arusarka opened this Issue Nov 10, 2010 · 3 comments

Projects

None yet

3 participants

@arusarka

it is exiting with 0 code on failures also. which is making the CI server function incorrectly.

@infews
Contributor
infews commented Nov 10, 2010

What's your configuration? I don't think we're seeing this...

@arusarka

the standard jasmine.yml :

spec_files:

  • ../../vendor/gems/jasmine/jasmine-jquery.js
  • */[sS]pec.js

We had to vendorize jasmine though according to the blog http://pivotallabs.com/users/dwfrank/blog/articles/1427-jasmine-in-rails-3

in spec/javascripts/jsamine_runner.rb we have changed a line to
ENV["JASMINE_BROWSER"] = "firefox"

is there some other information you are looking for?

running rake jasmine:ci in bash.

@sarahmei

Seeing this too - rails 3/rspec 2. I run rake jasmine:ci, a spec fails, I get:

Finished in 0.05873 seconds
4 examples, 1 failure

But I do echo $? and it's 0.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment