Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Structured JsApiReporter with specs inside suites #593

Closed
linssen opened this Issue May 16, 2014 · 5 comments

Comments

Projects
None yet
3 participants

linssen commented May 16, 2014

Currently the reporter gives a flat list of all specs and a flat list of all suites, but they're not linked in any way (other than an inherited title).

Would you consider building a tree of suites and tests as they pass / fail. So a driver could use the reporter to build an accurate representation of the suites?

Contributor

infews commented Jun 23, 2014

We consciously moved away from this concept in 2.0 in order to reduce complexity in our implementation. We see the tree-building as a Reporter concern - see what the HtmlReporter does to give you the HTML page of results.

Is there something specific that you are trying to accomplish?

linssen commented Jun 23, 2014

I'm parsing the API results with Python / Nose and using a generator to create separate tests which works perfectly.

I'd like to be able to at least say, when a test fails, which suite it belongs to, otherwise it's a bit tricky to track down. I think perhaps a reference to the spec's parent would be great, otherwise the suites array isn't that useful as I can see.

I'm more than happy to plug it in and send a PR so you can decide for yourself?

Contributor

infews commented Aug 27, 2014

We consciously removed such references in 2.0. We found that having direct references back to the spec/suite a) used a lot of memory and b) exposed implementation of the guts of Jasmine.

What information do you need/want in order to track down the suite? As I mentioned, the reporter is calling in a nested fashion.

@infews infews added the waiting label Aug 27, 2014

Owner

slackersoft commented Dec 16, 2014

We haven't heard much other feedback on this from the community, so I'm going to close this.

As @infews mentioned, the reporter is being notified of suites and specs according to the hierarchy of your entire suite. So a specStart following a suiteStart and before a suiteDone is a child of the suite.

linssen commented Dec 17, 2014

Sounds fair. Apologies for the inactivity: it slipped off my radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment