Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe the naming for the function it() #1772

Merged
merged 1 commit into from Jan 11, 2020

Conversation

@johnlinp
Copy link
Contributor

johnlinp commented Dec 16, 2019

Description

When I first saw it(), I was wondering if the name "it" is an abbreviation of anything. After some search, I finally realized that the name is only a pronoun. Therefore, I think it's worthwhile to include it in the documentation.

Motivation and Context

Described above.

How Has This Been Tested?

It's about documentation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@johnlinp johnlinp changed the title Describe the naming for the function it(). Describe the naming for the function it() Dec 16, 2019
When I first saw it(), I was wondering if the name "it" is
an abbreviation of anything. After some search, I finally
realized that the name is only a pronoun. Therefore, I
think it's worthwhile to include it in the documentation.
@johnlinp johnlinp force-pushed the johnlinp:add-it-naming branch from 06eabac to 6c766b7 Dec 16, 2019
@johnlinp

This comment has been minimized.

Copy link
Contributor Author

johnlinp commented Dec 17, 2019

Hi @slackersoft,

Can you please take a look at this? Thank you.

sgravrock added a commit to sgravrock/jasmine that referenced this pull request Jan 11, 2020
@sgravrock sgravrock merged commit 6c766b7 into jasmine:master Jan 11, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@johnlinp johnlinp deleted the johnlinp:add-it-naming branch Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.