Introducing `pageURI` method to handle test cases links with custom location. #197

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
5 participants

stas commented Mar 5, 2012

Basically this should solve issues like #177.
Developer should be able to customize pageURI method for the reporter he's using.
Ex.:

var jasmineEnv = jasmine.getEnv();
var reporter = new jasmine.TrivialReporter();
reporter.pageURI = function(path){ return window.location.pathname + path };
jasmineEnv.addReporter(reporter);
jasmineEnv.execute();
jasmine.HtmlReporter.SpecView.prototype.pageURI = function(path){ return window.location.pathname + path };
var jasmineEnv = jasmine.getEnv();
var reporter = new jasmine.HtmlReporter();
jasmineEnv.addReporter(reporter);
jasmineEnv.execute();

stas added some commits Mar 5, 2012

@stas stas Introducing `pageURI` method to handle test cases links with custom l…
…ocation.

Basically this should solve issues like #177.
Developer should be able to customize `pageURI` method for the reporter he's using.
Ex.:

```javascript
var jasmineEnv = jasmine.getEnv();
var reporter = new jasmine.TrivialReporter();
reporter.pageURI = function(path){ return window.location.pathname + path };
jasmineEnv.addReporter(reporter);
jasmineEnv.execute();
```
13cd56a
@stas stas Cleanups. 85a888c
@stas stas Add `pageURI` helper to cover HTMLReporter calls too. c741f4b
Contributor

ragaskar commented May 14, 2012

If tests pass this makes sense to me. Story here: https://www.pivotaltracker.com/story/show/29578495

great - cheers for fixing this

Contributor

infews commented May 27, 2013

Can you resubmit this request on top of master? The HtmlReporter is drastically different these days. Resubmitting will get this inot 2.0.

Thanks for making Jasmine great!

Owner

slackersoft commented Oct 2, 2013

We'd love to get this in. We'll look at prioritizing it again after 2.0. If you want to resubmit on top of master, we can probably get it in sooner.

slackersoft closed this Oct 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment