Minor cleanups #207

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants
@jlaire

jlaire commented Mar 30, 2012

Fix some typos and simplify a few code snippets.

Johannes Laire added some commits Mar 30, 2012

Johannes Laire
make coding style more consistent
This doesn't change semantics, but usually loop variables that are used
in more than one loop seem to be declared before them.
Johannes Laire
remove unnecessary conditionals
In code like this:

    if (arr.length > 0) {
      for (var i = 0; i < arr.length; ++i) { ... }
    }

The check is pointless and adds unnecessary indentation.
@ragaskar

This comment has been minimized.

Show comment Hide comment
@ragaskar

ragaskar May 2, 2012

Contributor

Looks good. Can't be auto-merged so it may take a bit before we come back and merge it in. Thanks!

Contributor

ragaskar commented May 2, 2012

Looks good. Can't be auto-merged so it may take a bit before we come back and merge it in. Thanks!

@infews

This comment has been minimized.

Show comment Hide comment
@infews

infews Oct 26, 2012

Contributor

If you're still interested in these, can you please re-apply to HEAD? Thanks for your help.

Contributor

infews commented Oct 26, 2012

If you're still interested in these, can you please re-apply to HEAD? Thanks for your help.

@infews

This comment has been minimized.

Show comment Hide comment
@infews

infews May 27, 2013

Contributor

Closing due to inactivity.

Contributor

infews commented May 27, 2013

Closing due to inactivity.

@infews infews closed this May 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment