Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Makes Jasmine work with the iPhone mobile JVM compiler #23

Closed
wants to merge 2 commits into from

4 participants

@RiverGlide

The Titanium/iPhone mobile JVM compiler trips over this syntax without the surrounding brackets (or if block). The following thread describes the reason for this change:
http://groups.google.com/group/jasmine-js/browse_thread/thread/4672d801ca59e8cc

@ragaskar
Owner

I'll try to pull one of these soon. Trying to imagine a test for this ....

@RiverGlide

Just to clarify, it's actually the Apple Javascript interpreter, not a "JVM", as such.

@ragaskar
Owner

We're going through old pull requests and trying to get them into the Jasmine mainline. Can you add a test to this commit that shows the use case of this change? Thanks!

@antonymarcano

We're not sure if this is still an issue. We may have a chance to look at this over the coming week. It's probably going to be hard to add a test for it since functionality shouldn't change... So unless there is a means to run the existing test suite on the titanium platform in an iPhone simulator, it might be hard to demonstrate with an isolated test... Like I said, we'll try to investigate to see if it's still an issue. There may now be other parts of the code that exhibit this problem since we've not tried to use Jasmine with titanium for a while, or the interpreter may support the syntax now .

@infews
Owner

Closing due to inactivity. Please re-open with a test if it's still an issue.

@infews infews closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 13, 2010
  1. @RiverGlide
Commits on Oct 14, 2010
  1. @RiverGlide
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  src/base.js
View
2  src/base.js
@@ -106,7 +106,7 @@ jasmine.ExpectationResult.prototype.passed = function () {
* Getter for the Jasmine environment. Ensures one gets created
*/
jasmine.getEnv = function() {
- return jasmine.currentEnv_ = jasmine.currentEnv_ || new jasmine.Env();
+ return (jasmine.currentEnv_ = jasmine.currentEnv_ || new jasmine.Env());
};
/**
Something went wrong with that request. Please try again.