Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

make it easier to copy the title of a failing spec #295

Closed
wants to merge 1 commit into from

3 participants

@herval

as per: #287

@infews
Owner

Can you please re-do this on top of master? The code's changed quite a bit and I'm not sure if this still applies.

@infews
Owner

Closing as duplicate.

@infews
Owner

Actually, scratch that. This pull is a little better. Herval, can you re-do this on master. The HtmlReporter is much improved (faster, cleaner). But I'm not sure this issue doesn't still exist.

Can you take a look, and if it's fixed, close. Else, a new pull is welcome.

@slackersoft
Owner

Made a tracker story to look at this for 2.0: https://www.pivotaltracker.com/story/show/58121820

@slackersoft slackersoft closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
28 src/html/SpecView.js
@@ -7,19 +7,29 @@ jasmine.HtmlReporter.SpecView = function(spec, dom, views) {
this.dom.symbolSummary.appendChild(this.symbol);
this.summary = this.createDom('div', { className: 'specSummary' },
- this.createDom('a', {
- className: 'description',
- href: jasmine.HtmlReporter.sectionLink(this.spec.getFullName()),
- title: this.spec.getFullName()
- }, this.spec.description)
+ this.createDom('div', {
+ className: 'description'
+ },
+ this.createDom('a', {
+ href: jasmine.HtmlReporter.sectionLink(this.spec.getFullName()),
+ title: this.spec.getFullName()
+ },
+ this.spec.description
+ )
+ )
);
this.detail = this.createDom('div', { className: 'specDetail' },
+ this.createDom('div', {
+ className: 'description'
+ },
this.createDom('a', {
- className: 'description',
- href: '?spec=' + encodeURIComponent(this.spec.getFullName()),
- title: this.spec.getFullName()
- }, this.spec.getFullName())
+ href: '?spec=' + encodeURIComponent(this.spec.getFullName()),
+ title: this.spec.getFullName()
+ },
+ this.spec.getFullName()
+ )
+ )
);
};
View
5 src/html/_HTMLReporter.scss
@@ -277,11 +277,14 @@ body {
//line-height: $line-height * 2;
display: block;
- color: white;
background-color: $failing-color;
//font-size: $large-font-size;
}
+
+ .description a {
+ color: white;
+ }
}
}
View
2  src/version.js
@@ -3,5 +3,5 @@ jasmine.version_= {
"major": 1,
"minor": 2,
"build": 0,
- "revision": 1343710612
+ "revision": 1351872343
};
Something went wrong with that request. Please try again.