Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix test runner failures in IE 6/7/8 #305

Closed
wants to merge 1 commit into from

3 participants

@vikki

Fixing test runner failures in IE 6/7/8 whereby HtmlReporter.js bails out as we're using for (reserved keyword) as object property name. Fix is just to quote the name which allows IE6/7/8 to run the tests. I think this might also fix #303
n.b. there are a few failing tests on these platforms, not sure if they're supported though, will try to take a look

@unrulydevelopers unrulydevelopers Fixing test runner failures in IE 6/7/8 whereby HtmlReporter.js bails…
… out as we're using for (reserved keyword) as object property name. Fix is just to quote the name which allows IE6/7/8 to run the tests. I think this might also fix Issue #303 on main repo (jasmine#303)
dcf62f5
@ragaskar
Owner

This has been merged. Thanks!

@ragaskar ragaskar closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 3, 2012
  1. @unrulydevelopers

    Fixing test runner failures in IE 6/7/8 whereby HtmlReporter.js bails…

    unrulydevelopers authored
    … out as we're using for (reserved keyword) as object property name. Fix is just to quote the name which allows IE6/7/8 to run the tests. I think this might also fix Issue #303 on main repo (jasmine#303)
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  src/html/HtmlReporter.js
View
2  src/html/HtmlReporter.js
@@ -94,7 +94,7 @@ jasmine.HtmlReporter = function(_doc) {
dom.symbolSummary = self.createDom('ul', {className: 'symbolSummary'}),
dom.alert = self.createDom('div', {className: 'alert'},
self.createDom('span', { className: 'exceptions' },
- self.createDom('label', { className: 'label', for: 'no_try_catch' }, 'No try/catch'),
+ self.createDom('label', { className: 'label', 'for': 'no_try_catch' }, 'No try/catch'),
self.createDom('input', { id: 'no_try_catch', type: 'checkbox' }))),
dom.results = self.createDom('div', {className: 'results'},
dom.summary = self.createDom('div', { className: 'summary' }),
Something went wrong with that request. Please try again.