Patch for better stack traces #46

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
@jrsacks

jrsacks commented Jan 26, 2011

No longer rewriting the stack trace from jasmine.ExpectationResult which results in much more detailed stack traces.

@infews

This comment has been minimized.

Show comment Hide comment
@infews

infews Jan 26, 2011

Does the trace property come through in the reporter page?

infews commented on 42d23c8 Jan 26, 2011

Does the trace property come through in the reporter page?

This comment has been minimized.

Show comment Hide comment
@jrsacks

jrsacks Jan 26, 2011

Owner

I am running Jasmine using jasmine-node and am only looking at the spec results in the console. The only piece of the trace that had been showing up was in the Jasmine code rather than the trace through my code where the specs were failing.

Owner

jrsacks replied Jan 26, 2011

I am running Jasmine using jasmine-node and am only looking at the spec results in the console. The only piece of the trace that had been showing up was in the Jasmine code rather than the trace through my code where the specs were failing.

@sconover

This comment has been minimized.

Show comment Hide comment
@sconover

sconover Jan 28, 2011

Contributor

This is a big deal for us node folks, stack traces through jasmine are useless without this patch.

+1

Contributor

sconover commented Jan 28, 2011

This is a big deal for us node folks, stack traces through jasmine are useless without this patch.

+1

@muhqu

This comment has been minimized.

Show comment Hide comment
@muhqu

muhqu Feb 16, 2011

+1 I have the same issue with jasmine-node.

muhqu commented Feb 16, 2011

+1 I have the same issue with jasmine-node.

@sconover

This comment has been minimized.

Show comment Hide comment
@sconover

sconover Feb 26, 2011

Contributor

Hi pivotal could you please merge this?

Contributor

sconover commented Feb 26, 2011

Hi pivotal could you please merge this?

@truelson

This comment has been minimized.

Show comment Hide comment
@truelson

truelson Mar 7, 2011

I have to pile on with this one as well. jasmine-node needs this patch. With this patch, jasmine-node becomes the PERFECT means to test javascript applications (like Titanium apps). And jasmine-node won't take this patch since it's a patch to the jasmine library itself.

truelson commented Mar 7, 2011

I have to pile on with this one as well. jasmine-node needs this patch. With this patch, jasmine-node becomes the PERFECT means to test javascript applications (like Titanium apps). And jasmine-node won't take this patch since it's a patch to the jasmine library itself.

@fabiomcosta

This comment has been minimized.

Show comment Hide comment
@fabiomcosta

fabiomcosta Apr 20, 2011

Contributor

This should really go in, +1

Contributor

fabiomcosta commented Apr 20, 2011

This should really go in, +1

@abierbaum

This comment has been minimized.

Show comment Hide comment
@abierbaum

abierbaum Apr 25, 2011

+1. This commit takes jasmine from being great to being awesome.

+1. This commit takes jasmine from being great to being awesome.

@timoxley

This comment has been minimized.

Show comment Hide comment
@timoxley

timoxley May 22, 2011

+1 Agreed

+1 Agreed

@sconover

This comment has been minimized.

Show comment Hide comment
@sconover

sconover May 22, 2011

Contributor

+1000 PLEASE MERGE THIS, I'M BEGGING YOU

Contributor

sconover commented May 22, 2011

+1000 PLEASE MERGE THIS, I'M BEGGING YOU

@alexch

This comment has been minimized.

Show comment Hide comment
@alexch

alexch May 22, 2011

+1 HULK SMASH PUNY STACK TRACE

alexch commented May 22, 2011

+1 HULK SMASH PUNY STACK TRACE

@brentlintner

This comment has been minimized.

Show comment Hide comment
@brentlintner

brentlintner May 30, 2011

+1!

+1!

@rafaelcaricio

This comment has been minimized.

Show comment Hide comment
@rafaelcaricio

rafaelcaricio May 30, 2011

+1, please!

+1, please!

@dcrec1

This comment has been minimized.

Show comment Hide comment
@dcrec1

dcrec1 May 31, 2011

+1

dcrec1 commented May 31, 2011

+1

@plentz

This comment has been minimized.

Show comment Hide comment
@plentz

plentz May 31, 2011

+1

plentz commented May 31, 2011

+1

@aoqfonseca

This comment has been minimized.

Show comment Hide comment
@aoqfonseca

aoqfonseca May 31, 2011

+1

+1

@avelino

This comment has been minimized.

Show comment Hide comment
@avelino

avelino Jun 1, 2011

+1

avelino commented Jun 1, 2011

+1

@infews

This comment has been minimized.

Show comment Hide comment
@infews

infews Jun 1, 2011

Contributor

To clarify - this provides more useful stack traces for Node. Understood. A little more digging and I found this: https://github.com/eriwen/javascript-stacktrace/blob/master/stacktrace.js which suggests that e.stack is available in Chrome and Firefox as well, though the acutal info is different. Safari and IE are (possibly) better served by the existing implementation (which remains in this patch).

Contributor

infews commented Jun 1, 2011

To clarify - this provides more useful stack traces for Node. Understood. A little more digging and I found this: https://github.com/eriwen/javascript-stacktrace/blob/master/stacktrace.js which suggests that e.stack is available in Chrome and Firefox as well, though the acutal info is different. Safari and IE are (possibly) better served by the existing implementation (which remains in this patch).

@infews

This comment has been minimized.

Show comment Hide comment
@infews

infews Jun 2, 2011

Contributor

Closing as a version of this is now on master.

Contributor

infews commented Jun 2, 2011

Closing as a version of this is now on master.

@infews infews closed this Jun 2, 2011

@timoxley

This comment has been minimized.

Show comment Hide comment
@timoxley

timoxley Jun 2, 2011

whoo thanks

timoxley commented Jun 2, 2011

whoo thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment