Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you guess correctly, make the person's name a link to their directory profile #32

Closed
botwhytho opened this issue Apr 1, 2017 · 1 comment · Fixed by #45
Closed
Labels
enhancement front-end Relating to the client-side JavaScript help wanted

Comments

@botwhytho
Copy link
Collaborator

Quick way to learn a bit more about somebody else. Having that quick context and linking somebody's name and face with 'likes Ruby' from their profile/bio facilitates learning.

This should be a quick one as we already have all the information to do this. Somebody's profile has the format https://www.recurse.com/directory/[person ID]-[first name]-[last name].

This could be combined with #29 as the same React component needs to be modified on both. #29 requires some additional changes in React and on the SQL query side but changes are not that involved.

@jasonaowen jasonaowen added the front-end Relating to the client-side JavaScript label Apr 5, 2019
@jasonaowen
Copy link
Owner

The back end already includes the person ID in the API response, so the front end should have everything it needs to generate this link.

jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 8, 2019
jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 9, 2019
jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 9, 2019
jaryncolbert added a commit that referenced this issue Apr 9, 2019
Issue #32 - Add link to Directory profile to correct answers
jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement front-end Relating to the client-side JavaScript help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants