Fixes #52 - Enable .env support with python-dotenv #54
Conversation
There was a problem hiding this comment.
Thank you for working on this! This is an even more comprehensive and automated approach than I imagined. 🤖 I also really appreciate your detailed documentation, including the descriptive error message for missing values. 💜
I have a few small notes on the PostgreSQL connection strings, as well as an optional suggestion for improving some Python readability.
| `postgres://localhost/faces` | ||
| or | ||
| `postgres:///faces`, | ||
| to connect over TCP/IP to the database named `faces`. |
There was a problem hiding this comment.
I think this got modified in the move. postgres:///faces connects over the Unix domain socket to the database named faces, and I think should probably be the default; postgresql://localhost/ connects over TCP/IP to the default database for your user.
There was a problem hiding this comment.
Sorry, now that I reread this, I was very unclear about what my concern was here!
Right now, this sentence says:
Alternate database URLs you might try are
postgres://localhost/facesorpostgres:///faces, to connect over TCP/IP to the database namedfaces.
The former connects via TCP/IP, but the latter connects via a Unix domain socket, so the explanation at the end is wrong.
Perhaps it could read:
An alternate database URL you might try is:
postgres://localhost/facesto connect over TCP/IP to the database namedfaces.
There was a problem hiding this comment.
Ahh, sorry for the misunderstanding! Corrected with your suggestion 😄
|
Just made all the changes requested and re-pushed |
| enable the variable `REACT_APP_USE_TEST_DATA=true`, | ||
| and then starting the React app is as simple as: | ||
| ```sh | ||
| $ npm run start |
…te README to describe how to populate file from provided env.template
This commit adds the python-dotenv dependency to manage environment variables, removing the need to specify them in line with the commands to use test data, run the database updates, and start the Flask app.
The README now includes a section on how to copy the provided
env.templateand modify it to populate the required variables in a new.envfile that will not be under version control (and was added to.gitignore.The Flask environment variables
FLASK_APPandFLASK_ENVcan be safely added to version control, and are included in the new.flaskenvfile. Thepython-dotenvlibrary will combine the two with.envtaking precedence over.flaskenvif there are conflicts.