Restructure Project Directory Layout

[jasonsiders]

This PR restructures the project's folder organization by consolidating all Salesforce source code into a dedicated source directory.

Changes

• Directory Structure: Moved all Salesforce metadata from force-app/main/default/ to source/
  • Classes, layouts, objects, and field definitions relocated
  • Updated all package configuration files (sfdx-project.json) to reference new paths
• CI/CD Updates: Updated GitHub Actions workflows and scripts to use new source directory
• Configuration Updates: Modified .forceignore and .gitignore to align with new structure

Benefits

• Simplified Structure: Cleaner project layout with source code clearly separated
• Consistent Packaging: Both managed and unlocked package configurations now reference the same source directory
• Improved Maintainability: Easier to navigate and maintain codebase with dedicated source folder

Impact

• No functional changes to the library code itself
• All existing functionality remains intact
• Package deployment paths updated but package contents unchanged

[claude]

Claude finished @jasonsiders's task —— View job

---

Code Review: Directory Restructuring ✅

Todo List:

• Analyze configuration file changes
• Review file path consistency across all references
• Check build and deployment configuration updates
• Assess potential impacts and provide comprehensive feedback
• Submit final review

---

Review Summary ✅

This PR successfully restructures the repository by moving all Salesforce source files from force-app/main/default/ to a dedicated source/ directory. The changes are well-coordinated and maintain consistency across all configuration files.

Code Quality & Best Practices ✅

Excellent execution of folder restructuring:

• All file moves are clean renames (0 additions/deletions per file)
• Consistent path updates across all configuration files
• Follows Salesforce DX project structure best practices
• Maintains proper metadata structure (classes/, objects/, layouts/)

Configuration Updates ✅

All critical configuration files properly updated:

1. SFDX Project Files - All updated correctly:

   • Root sfdx-project.json:4 - "path": "source"
   • packages/managed/sfdx-project.json:4 - "path": "source"
   • packages/unlocked/sfdx-project.json:4 - "path": "source"

2. CI/CD Pipeline - Properly configured:

   • .github/workflows/ci.yml:8 - Path trigger updated to "source/**"
   • .github/workflows/ci.yml:83 - Source directory correctly referenced in delta generation
   • .github/workflows/ci.yml:198 - Deploy command uses --source-dir source
   • .github/workflows/release.yml:8 - Path trigger updated to "source/**"
   • .github/scripts/static_analysis.py:98,115 - Default target and path handling updated

3. Ignore Files - Consistently updated:

   • .forceignore:15-16 - References updated to source/objectTranslations/** and source/profiles/**
   • .gitignore:51-52 - Same pattern updates

Potential Issues 🔍

No significant issues identified:

• ✅ No broken file references detected
• ✅ All metadata relationships preserved
• ✅ CI/CD pipelines properly updated
• ✅ Static analysis configuration aligned

Performance Considerations ✅

Neutral to positive impact:

• No performance implications from folder restructuring
• CI pipeline path filtering remains efficient with source/** pattern
• Static analysis scope properly maintained

Security Concerns ✅

No security issues:

• No sensitive files exposed or moved inappropriately
• Ignore patterns for sensitive metadata maintained
• CI/CD security context preserved

Test Coverage 📊

Test structure maintained:

• All test files (*Test.cls) properly moved to source/classes/
• CI workflow test execution path updated correctly (.github/workflows/ci.yml:198)
• Code coverage requirements unchanged (100% still enforced)

Recommendations 💡

1. Consider updating README - If there are any developer setup instructions referencing the old file structure
2. Verify IDE integration - Developers may need to refresh their Salesforce DX projects in IDEs
3. Update local development - Team members will need to pull changes and may need to refresh scratch orgs

Impact Assessment 📈

Low risk, high organization benefit:

• ✅ Improves project organization and follows Salesforce DX conventions
• ✅ Makes source code location more explicit and discoverable
• ✅ All automation and CI/CD processes properly updated
• ⚠️ Developers will need to pull changes and may need scratch org refresh

This is a well-executed structural improvement that enhances project organization while maintaining full functional compatibility.

---

[github-actions]

✅ Static Analysis: Check Passed

Analyzed changed files, and found 0 potential violations. 0 meets or exceeds the set severity threshold: Info

⚫ 0 Critical severity violation(s)
🔴 0 High severity violation(s)
🟠 0 Medium severity violation(s)
🟡 0 Low severity violation(s)
⚪ 0 Info severity violation(s)