-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
| assert(!sock.isOpen); | ||
| ubyte[1] buff; | ||
| assert(pair[0].receive(buff) == Socket.ERROR); | ||
| assert(errno == EBADF); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Referencing EBADF is failing the Windows build.
|
I'd like to merge this, but the two new files are missing the copyright header. I'm a bit inexperienced with this part of open source, but I think the best approach is to use the same copyright header as the other files and list yourself as the sole author (in the |
|
|
||
| sock.write(data); | ||
| assert(other.receive(buff) == Socket.ERROR); | ||
| assert(errno == EAGAIN); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows build is failing here now.
|
Using std.socket as a basis for a new I/O library is bad idea, b/c you inherit all the bad parts (e.g. usage of GC allocated class). |
|
I agree. This needs to be rewritten to not use |
I agree that std.socket should be replaced with something that doesn't depend use GC allocated objects, but I don't think that will be a simple task. I would be happy to help work on it though. |
|
Taking a look at the Handle based io.file.stream would be a good starting point. We also established a few principles like using scattered |
Which is OK for a |
No description provided.