-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could the encryption be made optional? #7
Comments
Hi! I would be interested in making encryption optiona as welll, though my main use case is the local storage backend. There are filesystems with built-in compression and that would be a neat way to make use of it. In my case it would reduce the bloat by a factor of ~3. I had a look at the branch created 2019, which introduced the option, but never made it into main. Would you consider accepting a PR with the code from 2019 adapted to the current version? I can test it with the local backend, but I don't have any means to test it on S3. |
Yes, I'm always open to PRs! Adapting that old PR to recent changes should be relatively straightforward. The main thing is that the When you have a PR, I can test it on S3. (I have a free-tier account that I test with.) |
I'm working on implementing this here: https://github.com/greyltc/rudolfs/tree/encryption-optional based on what you've already done in #8 Jason. |
@jasonwhite tested. working like a charm! thanks very much! |
@jasonwhite could we get a 0.3.7 tag for this? |
@greyltc Done. |
I would like my files to be accessible on the s3 repo for distribution via e.g. cloudfront.
The text was updated successfully, but these errors were encountered: