Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to enable changing border + resetting it #109

Closed
thebigsmileXD opened this issue Oct 16, 2017 · 5 comments
Closed

Option to enable changing border + resetting it #109

thebigsmileXD opened this issue Oct 16, 2017 · 5 comments

Comments

@thebigsmileXD
Copy link
Contributor

@thebigsmileXD thebigsmileXD commented Oct 16, 2017

  • This issue isn't duplicated - you can check if it is by using the search bar located at the top left hand corner and select "Issues" on the left.
  • This issue includes appropriate markdown for sections - e.g. code blocks for crash dumps.
  • This issue is understandable - feel free to use your native language to write issues if you are not comfortable with English.

Issue description

Due to using old MyPlot worlds, /p reset does not reset the border where users previousely were able to build
Also, not everyone likes stone slab borders

Reproducing the issue

  1. Use old world
  2. use /plot reset confirm

Client information

PocketMine-MP Version: *
Plugin Version: *
PHP version: 7.2 (default)

Optional information

@jasonwynn10

This comment has been minimized.

Copy link
Owner

@jasonwynn10 jasonwynn10 commented Oct 17, 2017

Slabs are simply the default border. it can easily be changed in the config to another block of choice or air

@thebigsmileXD

This comment has been minimized.

Copy link
Contributor Author

@thebigsmileXD thebigsmileXD commented Oct 17, 2017

You misunderstood: I want players to change the slabs on their own plots

@jasonwynn10 jasonwynn10 added this to Work In Progress in New Features Feb 18, 2019
@jasonwynn10 jasonwynn10 pinned this issue Feb 28, 2019
@jasonwynn10

This comment has been minimized.

Copy link
Owner

@jasonwynn10 jasonwynn10 commented Feb 28, 2019

Here's a plugin script that will allow players to change the plot borders. This will hopefully satisfy needs until the branch is merged.

https://gist.github.com/jasonwynn10/69acd21fd4878c502de9651d25b68199

@GamerDaniel3000

This comment has been minimized.

Copy link

@GamerDaniel3000 GamerDaniel3000 commented Mar 3, 2019

Hey Jason
If I release the property then the edge still remains the way I changed it.
Please correct that then the edge resets to the config setting.

@jasonwynn10

This comment has been minimized.

Copy link
Owner

@jasonwynn10 jasonwynn10 commented Mar 3, 2019

The edge should only be reset if it is able to be changed. Since the feature is not currently implemented, it will not be added until the rest of the plot-borders feature is added

@jasonwynn10 jasonwynn10 added this to To Do in BC-Breaks via automation Aug 23, 2019
@jasonwynn10 jasonwynn10 mentioned this issue Jan 2, 2020
6 of 6 tasks complete
New Features automation moved this from Work In Progress to Completed Jan 2, 2020
BC-Breaks automation moved this from To Do to Done Jan 2, 2020
@jasonwynn10 jasonwynn10 unpinned this issue Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
New Features
  
Completed
BC-Breaks
  
Done
3 participants
You can’t perform that action at this time.