Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use slug for team name #134

Merged
merged 1 commit into from Jun 30, 2020
Merged

use slug for team name #134

merged 1 commit into from Jun 30, 2020

Conversation

mtgto
Copy link
Contributor

@mtgto mtgto commented Jun 30, 2020

It should use team.slug instead of team.name.

GitHub API uses the team's slug as parameter, which is generated by team's name.
ex. https://developer.github.com/v3/teams/#get-a-team-by-name

For instance, Jasper recognize team name as "foo/bar@baz" if team name is "foo/bar@baz".
But github creates slug as "bar-baz".

@h13i32maru h13i32maru merged commit ace1aea into jasperapp:master Jun 30, 2020
@h13i32maru
Copy link
Member

@h13i32maru h13i32maru commented Jun 30, 2020

👍

@mtgto mtgto deleted the fix_team_name branch Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants