Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch all subscribed repositories #65

Merged
merged 1 commit into from Sep 2, 2018

Conversation

@pocke
Copy link
Contributor

@pocke pocke commented Jul 29, 2018

Fix #64

Note

Fetching "watching stream" is too slow if user watches many repositories. For example, I watch about 800 repositories, so Jasper needs 40 requests because it has the following hack. It is very very slow! 馃槶

// hack: github api returns server error when queries is long and per_page is 2 or greater.
//return [watchings.map((watching)=> `repo:${watching}`).join(' ')];

I guess we can reduce the requests. But this pull request does not include the improvement because it is out of scope of this pull request. See #66

@h13i32maru
Copy link
Member

@h13i32maru h13i32maru commented Sep 2, 2018

Thank you!

@pocke pocke deleted the paginate-subscriptin branch Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants