Skip to content

Fetch all subscribed repositories#65

Merged
h13i32maru merged 1 commit intojasperapp:masterfrom
pocke:paginate-subscriptin
Sep 2, 2018
Merged

Fetch all subscribed repositories#65
h13i32maru merged 1 commit intojasperapp:masterfrom
pocke:paginate-subscriptin

Conversation

@pocke
Copy link
Contributor

@pocke pocke commented Jul 29, 2018

Fix #64

Note

Fetching "watching stream" is too slow if user watches many repositories. For example, I watch about 800 repositories, so Jasper needs 40 requests because it has the following hack. It is very very slow! 😭

// hack: github api returns server error when queries is long and per_page is 2 or greater.
//return [watchings.map((watching)=> `repo:${watching}`).join(' ')];

I guess we can reduce the requests. But this pull request does not include the improvement because it is out of scope of this pull request. See #66

@h13i32maru
Copy link
Member

Thank you!

@pocke pocke deleted the paginate-subscriptin branch September 2, 2018 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants