Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect input when Enter key is pressed #94

Merged
merged 1 commit into from Aug 25, 2019

Conversation

@giga811
Copy link
Contributor

@giga811 giga811 commented May 13, 2019

Issue

In browser view, when I am typing a comment and select emoji (:+1: etc) or mention a person (@giga811 etc) the DETECT_INPUT is lost.
It is causing app's keyboard shortcut being activated while I am typing.

It is happening when I select the item by pressing Enter. It doesn't happen when I click the item.

Fix

Run detect() function when the Enter key is pressed.
So that when I select emoji or person the detect function runs and correctly detecting the input.

before after
@h13i32maru h13i32maru merged commit 73240d4 into jasperapp:master Aug 25, 2019
@h13i32maru
Copy link
Member

@h13i32maru h13i32maru commented Aug 25, 2019

Thanks!

Loading

@giga811 giga811 deleted the od/fix-detect-input branch Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants