Some parent elements should be leaf elements #78

Closed
hugomg opened this Issue Feb 14, 2013 · 5 comments

Comments

Projects
None yet
3 participants

hugomg commented Feb 14, 2013

Blaze considers <base>, <keygen> and <source> elements as parent elements but they are void elements according to the spec:

http://www.whatwg.org/specs/web-apps/current-work/multipage/syntax.html#elements-0

Void elements
area, base, br, col, embed, hr, img, input, keygen, link, menuitem, meta, param, source, track, wbr

The spec also lists <menuitem>, <track> and <wbr> as allowed void elements but they aren't listed anywhere. (although these aren't really well supported by browsers so I don't think anyone is really missing them)

BTW, it would be nice if the comments in the source didn't point to a sucky site like w3schools :P

@jaspervdj jaspervdj closed this in 5a67309 Feb 18, 2013

Owner

jaspervdj commented Feb 18, 2013

I've fixed this. I released it as blaze-html-0.6.0.0 since this is a breaking change to the API. It shouldn't break builds for most people but I can't take the chance. Thanks for reporting!

@byorgey byorgey referenced this issue in fpco/stackage Feb 19, 2013

Closed

conduit 1.0, blaze-html 0.6, wai 1.4 #44

byorgey commented Feb 19, 2013

@jaspervdj , could you elaborate on what kind of breakage might occur in theory? Could this change cause compilation to fail, or would it be a semantic breakage only?

@byorgey byorgey referenced this issue in jgm/highlighting-kate Feb 19, 2013

Merged

Bump blaze-html upper bound to allow 0.6 #30

Owner

jaspervdj commented Feb 19, 2013

@byorgey Basically it changed the semantics of a few obscure, rarely used tags. Additionally, in case you were actually relying on these tags and their semantics, the compilation would fail as well, since the types changed.

byorgey commented Feb 19, 2013

Ah, good to know. So if compilation succeeds then it's likely that everything will just work?

Owner

jaspervdj commented Feb 19, 2013

Since we're talking about really rarely used tags here, I'd say that 99% of reverse dependencies will just work. If compilation succeeds, I would be really surprised if something doesn't work.

hugo-dc pushed a commit to hugo-dc/highlighting-kate that referenced this issue May 10, 2016

Bump blaze-html upper bound to allow 0.6.
I've tested that the package builds under blaze-html-0.6.  I'm
not sure how best to conduct tests to make sure the behavior hasn't changed.

See jaspervdj/blaze-html#78 for an
explanation of what changed in blaze-html.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment