A few improvements #27

Merged
merged 3 commits into from Apr 3, 2012

Projects

None yet

2 participants

Contributor
ozataman commented Apr 3, 2012

Hey Jasper,

Awesome job on the new release! I love the clarity in the new interface. A bit more boilerplate, but everything is much more obvious now.

I have ported one of my projects over to this, which was a bit painful, but the result is great.

I have made a number of changes/improvements I feel are necessary (and are actually required for my use cases!). I've added explanations to each commit, but let me know if you have any questions or comments.

Best,
Oz

ozataman added some commits Apr 3, 2012
@ozataman ozataman Use Snap.getParams instead of Snap.getPostParams
Forms are often used for filtering listings and it sometimes makes
sense to use GET requests while submitting a form. The Snap env should
support this for flexibility of use.
a0c950a
@ozataman ozataman Add runForm' and runFormWith' variants to Snap backend
We should not always *force* GET and POST treatment on forms. Users
should have the option of evaluating forms under GET queries for
flexibility of use.
fd972b9
@ozataman ozataman Let passed-in form attributes overwrite default behavior
Users may want GET forms on occasion; we should let them overwrite the
default behavior when an explicit value is passed in via the splice
tag. Attributes list will likely be empty or consist of 1-2 items, so
the concatenation here should be fine.
36bf3dd
@jaspervdj jaspervdj merged commit 2ff0e86 into jaspervdj:master Apr 3, 2012
Owner

I changed the interface a bit (see c4a5d4f), like we briefly discussed yesterday. It's on Hackage as digestive-functors-snap-0.3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment