Remove stopRecursion from dfSubView #28

Merged
merged 2 commits into from Apr 26, 2012

Projects

None yet

2 participants

@ozataman
Contributor

Hey Jasper,

Not sure why this was there in the first place, but it causes some issues when used multiple times in a single page. The first one allows recursion in children, which is what we want, but then calls stopRecursion and stops it for later subViews on the same page.

I saw no regression in my projects by removing this.

ozataman added some commits Apr 26, 2012
@ozataman ozataman Remove stopRecursion from dfSubView
It causes problems with multiple subview blocks on the same page by
preventing splice substitution inside of <dfLabel> and other similar
tags. This reduces flexibility for the user.
07cb1d1
@ozataman ozataman Merge remote-tracking branch 'refs/remotes/jasper/master' 52df552
Owner

Makes sense, thanks!

@jaspervdj jaspervdj merged commit 2032f90 into jaspervdj:master Apr 26, 2012
Owner

Uploaded to Hackage as digestive-functors-heist-0.3.0.1

Contributor

Great, thanks!

On Thu, Apr 26, 2012 at 5:19 PM, Jasper Van der Jeugt <
reply@reply.github.com

wrote:

Uploaded to Hackage as digestive-functors-heist-0.3.0.1


Reply to this email directly or view it on GitHub:

#28 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment