Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for rendering feeds with custom templates #652

Merged
merged 1 commit into from Nov 24, 2018

Conversation

Projects
None yet
3 participants
@abhin4v
Copy link
Contributor

abhin4v commented Jul 28, 2018

An example usage is as follows:

customRenderAtom :: FeedConfiguration -> Context String -> [Item String] -> Compiler (Item String)
customRenderAtom config context items = do
  atomTemplate     <- unsafeCompiler $ readFile "templates/atom.xml"
  atomItemTemplate <- unsafeCompiler $ readFile "templates/atom-item.xml"
  renderAtomWithTemplates atomTemplate atomItemTemplate config context items

This should also fix #625 as people will be able to add custom templates with tags.

Adds render{Rss,Atom}WithTemmplates function in the Web.Feed module
- so that feeds can be rendered with custom templates
@abhin4v

This comment has been minimized.

Copy link
Contributor Author

abhin4v commented Oct 20, 2018

@jaspervdj any comments on this?

@rabbitonweb

This comment has been minimized.

Copy link

rabbitonweb commented Nov 21, 2018

@jaspervdj I would be happy to see this feature in. Anything blocking it? Can we help with anything to push this through?

@jaspervdj jaspervdj merged commit f3a1745 into jaspervdj:master Nov 24, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.