Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications #1

Merged
merged 9 commits into from Jan 5, 2020
Merged

Modifications #1

merged 9 commits into from Jan 5, 2020

Conversation

@lehins
Copy link
Contributor

lehins commented Jan 4, 2020

Hey @jaspervdj

I noticed that you did released this project, which you've mentioned to me before, so I decided to mess with it a little.

I've tried a few things, which I thought, should have improved the performance, but none of the changes I made affected the runtime, which is pretty good news, I think.

Because this PR does not make anything faster, fee free to ignore it. At the same time, I still wanted to submit this PR, regardless of the runtime, because there are changes that simplify things a bit, so go ahead and cherry pick things that you find an improvement yourself, if any.

lehins added 9 commits Jan 3, 2020
Fix threshold spelling
@jaspervdj

This comment has been minimized.

Copy link
Owner

jaspervdj commented Jan 4, 2020

Wow, thanks @lehins! I was just about to finish a short blogpost about this; you can see that here.

I quite like the modifications you made; and I'll have a look. One thing I'd like to keep though is the option of having a pure generator (i.e. ST rather than IO). I'll see if I can add that back on top of your changes.

@lehins lehins mentioned this pull request Jan 5, 2020
@jaspervdj jaspervdj merged commit 8640e29 into jaspervdj:master Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.