Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sundry build script fixes #22

Merged
merged 6 commits into from Sep 6, 2011

Conversation

Projects
None yet
2 participants
@jglick
Copy link

commented Aug 16, 2011

Various changes to build script to make it build cleanly from the NetBeans IDE. Tested with "Automatic Projects" plugin (available from Plugin Manager, with fix of https://netbeans.org/bugzilla/show_bug.cgi?id=153234 to be available in dev versions).

Jesse Glick added some commits Aug 16, 2011

Jesse Glick
Move misleading project metadata out of the way.
Should be friendlier to the NetBeans IDE.

1. A project should not have a "pom.xml" at top level (or preferably anywhere)
   unless it is really a Maven-based project and pom.xml gives all relevant
   information about the sources, which is certainly not the case here.

2. nbproject/project.xml was that of an IDE-managed project, which is
   inappropriate here where there is a complex build.xml that does not (and
   cannot) conform to the expectations of that project type (e.g. different Java
   source levels for src/ and test/ dirs). Could use the "freeform" project type
   for such cases, but http://wiki.netbeans.org/AutomaticProjects should do just
   as well, with no IDE-specific metadata or administration.
Jesse Glick
Should specify tempdir prop to <junit> so as not to pollute versioned…
… dir with junit*.properties after aborted tests.
Jesse Glick
<formatter type="brief" usefile="false"/> has similar command-line be…
…havior to printsummary="yes" but allows Ant listeners like NetBeans to track progress.
Jesse Glick
Pass jna.builddir as an absolute path.
Otherwise various tests fail when the CWD used to invoke Ant is not the project basedir.
@jglick

This comment has been minimized.

Copy link
Author

commented Aug 16, 2011

Note: first commit probably needs trivial changes to merge with #20.

@twall

This comment has been minimized.

Copy link

commented on 4375271 Sep 6, 2011

Still waiting for someone that uses maven to fix up the details of pom.xml et al. to effect a proper push to a maven repository.

pom-fake.xml is probably not the right name (perhaps maven-dist.xml), but until that functionality is actually repaired, it's not worth the quibble.

twall added a commit that referenced this pull request Sep 6, 2011

Merge pull request #22 from jglick/master
Sundry build script fixes

@twall twall merged commit 8e6b046 into java-native-access:master Sep 6, 2011

twall added a commit that referenced this pull request Sep 6, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.