Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new junit-jupiter artifact ID of JUnit 5 #130

Closed
tlinkowski opened this issue Dec 19, 2019 · 1 comment
Closed

Add support for new junit-jupiter artifact ID of JUnit 5 #130

tlinkowski opened this issue Dec 19, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@tlinkowski
Copy link
Collaborator

Currently, we handle JUnit 5 by only handling an explicit dependency on junit-jupiter-api:

public enum TestEngine {
JUNIT_4("junit", "junit", "junit", "junit"),
JUNIT_5("org.junit.jupiter", "junit-jupiter-api", "org.junit.jupiter.api", "org.junit.platform.commons"),
TESTNG("org.testng", "testng", "testng", "testng");
private final String groupId;
private final String artifactId;
public final String moduleName;
public final String addOpens;
TestEngine(String groupId, String artifactId, String moduleName, String addOpens) {

However, since JUnit 5.4, a new aggregate junit-jupiter artifact is available.

We should handle this artifact in the same way as we handle junit-jupiter-api.


Issue inspired by #129.

@siordache
Copy link
Collaborator

Implemented by #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants