Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Some internal refactorings #79

Closed
tlinkowski opened this issue Apr 6, 2019 · 1 comment · Fixed by #88
Closed

Proposal: Some internal refactorings #79

tlinkowski opened this issue Apr 6, 2019 · 1 comment · Fixed by #88
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@tlinkowski
Copy link
Collaborator

tlinkowski commented Apr 6, 2019

@paulbakker, let me know if you'd be interested in accepting PRs for the following internal refactorings:

1. Cleanup of test-project and test-project-kotlin

Aligning to test-project-mixed:

  • removing duplication in build.gradle(.kts) and settings.gradle(.kts) files
  • removing redundant configuration (e.g. plugins { id 'org.javamodularity.moduleplugin' } at the start of every subproject)
  • introducing gradle.properties with library versions (jUnitVersion = 5.3.1)

2. Applying JavaProjectHelper in more places

Currently used only in CompileTask and CompileModuleInfoTask.

This would allow for splitting long methods into shorter ones for better readability.

@tlinkowski tlinkowski changed the title Proposal: Some refactorings & improvements Proposal: Some internal refactorings Apr 7, 2019
@paulbakker
Copy link
Collaborator

Yes, sounds good!

tlinkowski added a commit to tlinkowski/gradle-modules-plugin that referenced this issue Apr 14, 2019
tlinkowski added a commit to tlinkowski/gradle-modules-plugin that referenced this issue Apr 14, 2019
tlinkowski added a commit to tlinkowski/gradle-modules-plugin that referenced this issue Apr 18, 2019
tlinkowski added a commit to tlinkowski/gradle-modules-plugin that referenced this issue Apr 18, 2019
tlinkowski added a commit to tlinkowski/gradle-modules-plugin that referenced this issue Apr 18, 2019
@tlinkowski tlinkowski added this to the 1.6.0 milestone Aug 25, 2019
@tlinkowski tlinkowski added the enhancement New feature or request label Aug 25, 2019
@tlinkowski tlinkowski self-assigned this Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants