From 4224b9766c043f395cd406c1a3f8341e6f34a850 Mon Sep 17 00:00:00 2001 From: Valentyn Kolesnikov Date: Sun, 9 Mar 2025 04:19:09 +0200 Subject: [PATCH 1/4] JDK 24 Added to CI Configuration --- .github/workflows/maven.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index d4bbf41e..0eaa3256 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -14,7 +14,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, windows-latest, macOS-latest] - java: [11, 17, 21, 23] + java: [11, 17, 21, 23, 24] steps: - uses: actions/checkout@v4 From e1388bfd623e3a5812df49a2a7d0bc292b66ba03 Mon Sep 17 00:00:00 2001 From: Valentyn Kolesnikov Date: Sun, 9 Mar 2025 04:23:52 +0200 Subject: [PATCH 2/4] Added exception --- src/test/java/com/github/underscore/StringTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/java/com/github/underscore/StringTest.java b/src/test/java/com/github/underscore/StringTest.java index 104c4dbd..c29d2d22 100644 --- a/src/test/java/com/github/underscore/StringTest.java +++ b/src/test/java/com/github/underscore/StringTest.java @@ -3612,6 +3612,7 @@ void fromXmlStackoverflowObject() throws IOException { try { U.fromXmlMap(stringXml); } catch (Throwable throwable) { + System.out.println("!!! - " + throwable); assertTrue(throwable instanceof StackOverflowError); } } From 5db8471cbad044f2947e1c5224f7746dc2bcb046 Mon Sep 17 00:00:00 2001 From: Valentyn Kolesnikov Date: Sun, 9 Mar 2025 04:28:39 +0200 Subject: [PATCH 3/4] Improved exception check --- src/test/java/com/github/underscore/StringTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/java/com/github/underscore/StringTest.java b/src/test/java/com/github/underscore/StringTest.java index c29d2d22..06da00be 100644 --- a/src/test/java/com/github/underscore/StringTest.java +++ b/src/test/java/com/github/underscore/StringTest.java @@ -3612,8 +3612,8 @@ void fromXmlStackoverflowObject() throws IOException { try { U.fromXmlMap(stringXml); } catch (Throwable throwable) { - System.out.println("!!! - " + throwable); - assertTrue(throwable instanceof StackOverflowError); + assertTrue(throwable instanceof StackOverflowError + || throwable instanceof org.xml.sax.SAXParseException); } } From 515056412afc17b29eb6b9615628ed2458f9471f Mon Sep 17 00:00:00 2001 From: Valentyn Kolesnikov Date: Sun, 9 Mar 2025 04:35:02 +0200 Subject: [PATCH 4/4] Improved test --- src/test/java/com/github/underscore/StringTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/com/github/underscore/StringTest.java b/src/test/java/com/github/underscore/StringTest.java index 06da00be..db076884 100644 --- a/src/test/java/com/github/underscore/StringTest.java +++ b/src/test/java/com/github/underscore/StringTest.java @@ -3613,7 +3613,7 @@ void fromXmlStackoverflowObject() throws IOException { U.fromXmlMap(stringXml); } catch (Throwable throwable) { assertTrue(throwable instanceof StackOverflowError - || throwable instanceof org.xml.sax.SAXParseException); + || throwable instanceof IllegalArgumentException); } }