Skip to content
This repository has been archived by the owner on Mar 18, 2022. It is now read-only.

Ensure that inherited method information is collected for AsmClass #21

Merged
merged 1 commit into from
Jan 17, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions rmic/src/main/java/org/glassfish/rmic/asm/AsmClass.java
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,32 @@ public void loadNested(Environment env) {
}
}

private boolean basicCheckDone = false;
private boolean basicChecking = false;

// This code is copied from BinaryClass.java which ensures that inherited method
// information is gathered. Consider promoting this to the super class.
protected void basicCheck(Environment env) throws ClassNotFound {
if (tracing) env.dtEnter("AsmClass.basicCheck: " + getName());

if (basicChecking || basicCheckDone) {
if (tracing) env.dtExit("AsmClass.basicCheck: OK " + getName());
return;
}

if (tracing) env.dtEvent("AsmClass.basicCheck: CHECKING " + getName());
basicChecking = true;

super.basicCheck(env);

// Collect inheritance information.
if (doInheritanceChecks) {
collectInheritedMethods(env);
}

basicCheckDone = true;
basicChecking = false;
if (tracing) env.dtExit("AsmClass.basicCheck: " + getName());
}

}